-
Notifications
You must be signed in to change notification settings - Fork 34
TPL Update 2025-12-15 #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
TPL Update 2025-12-15 #1509
Conversation
a44e1d3 to
09bb31f
Compare
09bb31f to
18cf423
Compare
… docker containers
|
Heads up for you @chapman39 , Axom changed their default type for index: You will get a lot of warnings as errors. |
…ith into feature/chapman39/tpl-2025-12-15
…ith into feature/chapman39/tpl-2025-12-15
| version: [7.2.6] | ||
| externals: | ||
| - spec: py-sphinx@7.2.6 | ||
| - spec: py-sphinx@7.2.6 ^python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forget the exact error, but spack wasn't concretizing without this.
| prefix: /usr | ||
| openblas: | ||
| buildable: false | ||
| # Spack is insistent on building openblas in the CUDA container, so allow building from source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed then? Why have an external when we are building it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe non-cuda containers were finding openblas, which is why i figured i'd leave the external path just in case.
white238
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments were nitpicking and I don't want to hold up this being merged after someone else's review. Thanks for the hard slog @chapman39 !
Co-authored-by: Chris White <white238@llnl.gov>
Co-authored-by: Chris White <white238@llnl.gov>
this pr
componentsvariant to Axom's spack package axom#1740about CUDA
related PRs
next
Fixes #1525